Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades decoder to v1.10.0 #50

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Upgrades decoder to v1.10.0 #50

merged 1 commit into from
Aug 21, 2024

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Aug 21, 2024

PR Type

enhancement, configuration changes


Description

  • Upgraded the decoder service image in docker-compose.yml from version v1.9.1 to v1.10.0.
  • This change ensures the use of the latest features and improvements available in the decoder version v1.10.0.

Changes walkthrough 📝

Relevant files
Configuration changes
docker-compose.yml
Upgrade decoder image version in Docker Compose                   

docker-compose.yml

  • Updated the decoder image version from v1.9.1 to v1.10.0.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Signed-off-by: Leonardo Custodio <[email protected]>
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Aug 21, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Pin the decoder image version to include the patch number for better stability and predictability

To ensure the decoder service uses a specific version of the platform-decoder image,
it's recommended to pin the version not only to the minor version but also to the
patch version. This can help avoid unexpected behaviors due to automatic updates to
newer patch versions which might not have been tested with your application.

docker-compose.yml [31]

-image: enjin/platform-decoder:v1.10.0
+image: enjin/platform-decoder:v1.10.0-patch
 
Suggestion importance[1-10]: 8

Why: The suggestion to pin the image version to a specific patch version is a good practice for ensuring stability and predictability, as it prevents unexpected changes from automatic updates to newer patch versions.

8

@leonardocustodio leonardocustodio merged commit 244656e into master Aug 21, 2024
1 check passed
@leonardocustodio leonardocustodio deleted the add-decoder-v1100 branch August 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants