-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vexiiriscv: add options and conditions #2099
Conversation
maass-hamburg
commented
Oct 18, 2024
•
edited
Loading
edited
- have opensbi things behind a condition
Hi, It is a bit hidden, but then, those --vexii-args parameters will also make SpinalHDL generate a .py which provide more information to litex. See pythondata-cpu-vexiiriscv/pythondata_cpu_vexiiriscv/verilog/xxxx.py. here is an example of this generated .py :
Adding another variant for baremetal opensbi would be a better solution ? |
@Dolu1990 I understand the with-rva thing, even-though I thing that it would be preferable to have the option of the cups similar, so enabling it would be the same. for the opensbi thing, we want to use this cpu with zephyr, so there is no need opensbi. Also wo don't like our csr positions be changed. |
Yes right. Overall i did it like this to reduce the codebase to its minimum and avoid redondancy. (Human stack overflow ^^)
I'm totaly fine with your proposal. I would say, just remove the RVA related stuff from the PR, add the with_opensbi into the hash and that is good :) note that VexiiRiscv has no PMP support for now. I got some funding to implement, it is in my todo list, likely in the next few months it will come. |
this way opensbi things are only activated, when a linux variant is used. Signed-off-by: Fin Maaß <[email protected]>
7bc235f
to
773fb34
Compare
done |
Thanks :D |