Prepare 4.1.3 release (#485)

* Update changelog

* Fix npm audit vulnerabilities

* Update docs

* Update dependencies

CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 4.1.3 - 2022-11-07
+
+-   Removed: absolute maximum size for file uploads (#461)
+-   Fix: fail early on non-multipart submissions (#476)
+-   Add redis-repl tool (#451)
+-   Fix: ensure `survey.media` is available in view mode (#484)
+-   Fix timepicker in Finnish locales (enketo/enketo-core#916)
+-   Fix special string.replace sequences in Markdown (enketo/enketo-transformer#153)
+-   Fix evaluating absolute nodeset expressions with an attribute context node (enketo/openrosa-xpath-evaluator#166)
+
 ## 4.1.2 - 2022-09-16
 
 -   Fix: memory leak with async_hooks request context (#450)

README.md

@@ -1,4 +1,4 @@
-![coverage-shield-badge-1](https://img.shields.io/badge/coverage-79.27%25-yellow.svg)
+![coverage-shield-badge-1](https://img.shields.io/badge/coverage-79.3%25-yellow.svg)
 
 [![Build Status](https://travis-ci.com/enketo/enketo-express.svg?branch=master)](https://travis-ci.org/enketo/enketo-express)
 

docs/app_controllers_submission-controller.js.html

@@ -96,11 +96,25 @@ <h1 class="page-title">app/controllers/submission-controller.js</h1>
  * Simply pipes well-formed request to the OpenRosa server and
  * copies the response received.
  *
- * @param {module:api-controller~ExpressRequest} req - HTTP request
- * @param {module:api-controller~ExpressResponse} res - HTTP response
+ * @param {express.Request} req - HTTP request
+ * @param {express.Response} res - HTTP response
  * @param {Function} next - Express callback
  */
 async function submit(req, res, next) {
+    if (!req.headers['content-type']?.startsWith('multipart/form-data')) {
+        res.status(400)
+            .set('content-type', 'text/xml')
+            .send(
+                /* xml */ `
+                &lt;OpenRosaResponse xmlns="http://openrosa.org/http/response" items="0">
+                    &lt;message nature="error">Required multipart POST field xml_submission_file missing.&lt;/message>
+                &lt;/OpenRosaResponse>
+                `.trim()
+            );
+
+        return;
+    }
+
     try {
         const paramName = req.app.get('query parameter to pass to submission');
         const paramValue = req.query[paramName];

docs/index.html

@@ -65,8 +65,18 @@ <h3> </h3>
         <article><p><img src="https://img.shields.io/badge/coverage-79.27%25-yellow.svg" alt="coverage-shield-badge-1"></p>
 <p><a href="https://travis-ci.org/enketo/enketo-express"><img src="https://travis-ci.com/enketo/enketo-express.svg?branch=master" alt="Build Status"></a></p>
 <h1 id="enketo-express">Enketo Express</h1>
-<p><em>The modern <a href="https://enketo.org">Enketo Smart Paper</a> web application.</em></p>
+<p><em>The <a href="https://enketo.org">Enketo Smart Paper</a> web application.</em> It can be used directly by form servers or used as inspiration for building applications that wrap <a href="https://github.com/enketo/enketo-core">Enketo Core</a>. See <a href="https://enketo.org/develop/">this diagram</a> for a summary of how the different Enketo components are related.</p>
 <p><strong>To get started visit our <a href="https://enketo.github.io/enketo-express">technical documentation</a>.</strong></p>
+<h3 id="project-status">Project status</h3>
+<p>Enketo was initiated in 2009 by Martijn van de Rijdt as a web-based alternative or complement to <a href="https://docs.getodk.org/collect-intro/">ODK Collect</a>. It has become a core component of the ODK ecosystem and been adopted by several organizations beyond that ecosystem.</p>
+<p>As of 2022, Enketo is maintained by <a href="https://github.com/eyelidlessness/">Trevor Schmidt</a> and <a href="https://getodk.org/about/team.html">the ODK team</a>. Martijn continues to provide advice and continuity. The ODK project sets priorities in collaboration with its <a href="https://getodk.org/about/ecosystem.html">Technical Advisory Board</a>.</p>
+<p>Our current primary goals are:</p>
+<ul>
+<li>Increasing alignment with ODK Collect, particularly in service of submission edits.</li>
+<li>Improving error messages so that users can get out of bad states.</li>
+<li>Improving long-term maintainability by modernizing code bases, removing code duplication, and simplifying state mutation.</li>
+</ul>
+<p>Feature requests and project discussion are welcome on the <a href="https://forum.getodk.org/">ODK forum</a>.</p>
 <h3 id="translation">Translation</h3>
 <p>The user interface was translated by: Badisches Rotes Kreuz (German), Serkan Tümbaş (Turkish), Hélène Martin (French), Gurjot Sidhu(Hindi, Panjabi), &quot;Abcmen&quot; (Turkish), Otto Saldadze, Makhare Atchaidze, David Sichinava, Elene Ergeshidze (Georgian), Nancy Shapsough (Arabic), Noel O'Boyle (French), Miguel Moreno (Spanish), Tortue Torche (French), Bekim Kajtazi (Albanian), Marc Kreidler (German), Darío Hereñú (Spanish), Viktor S. (Russian), Alexander Torrado Leon (Spanish), Peter Smith (Portugese, Spanish), Przemysław Gumułka (Polish), Niklas Ljungkvist, Sid Patel (Swedish), Katri Jalava (Finnish), Francesc Garre (Spanish), Sounay Phothisane (Lao), Linxin Guo (Chinese), Emmanuel Jean, Renaud Gaudin (French), Trần Quý Phi (Vietnamese), Reza Doosti, Hossein Azad, Davood Mottalee (Persian), Tomas Skripcak (Slovak, Czech, German), Daniela Baldova (Czech), Robert Michael Lundin (Norwegian), Margaret Ndisha, Charles Mutisya (Swahili), Panzero Mauro (Italian), Gabriel Kreindler (Romanian), Jason Reeder, Omar Nazar, Sara Sameer, David Gessel (Arabic), Tino Kreutzer (German), Wasilis Mandratzis-Walz (German, Greek), Luis Molina (Spanish), Martijn van de Rijdt (Dutch).</p>
 <p><em>Send a message if you'd like to contribute! We use an easy web interface provided by <a href="https://www.transifex.com/projects/p/enketo-express/">Transifex</a>.</em></p>

docs/module-submissions-controller.html

@@ -98,7 +98,7 @@ <h4 class="name" id="~_logSubmission"><span class="type-signature">(inner) </spa
 
     <dt class="tag-source">Source:</dt>
     <dd class="tag-source"><ul class="dummy"><li>
-        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line197">line 197</a>
+        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line211">line 211</a>
     </li></ul></dd>
 
 
@@ -276,7 +276,7 @@ <h4 class="name" id="~getInstance"><span class="type-signature">(async, inner) <
 
     <dt class="tag-source">Source:</dt>
     <dd class="tag-source"><ul class="dummy"><li>
-        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line162">line 162</a>
+        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line176">line 176</a>
     </li></ul></dd>
 
 
@@ -458,7 +458,7 @@ <h4 class="name" id="~maxSize"><span class="type-signature">(inner) </span>maxSi
 
     <dt class="tag-source">Source:</dt>
     <dd class="tag-source"><ul class="dummy"><li>
-        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line126">line 126</a>
+        <a href="app_controllers_submission-controller.js.html">app/controllers/submission-controller.js</a>, <a href="app_controllers_submission-controller.js.html#line140">line 140</a>
     </li></ul></dd>
 
 
@@ -725,7 +725,7 @@ <h5>Parameters:</h5>
             <td class="type">
 
 
-<span class="param-type"><a href="module-api-controller.html#~ExpressRequest">module:api-controller~ExpressRequest</a></span>
+<span class="param-type">express.Request</span>
 
 
 
@@ -748,7 +748,7 @@ <h5>Parameters:</h5>
             <td class="type">
 
 
-<span class="param-type"><a href="module-api-controller.html#~ExpressResponse">module:api-controller~ExpressResponse</a></span>
+<span class="param-type">express.Response</span>
 
 
 

package.json

@@ -2,7 +2,7 @@
     "name": "enketo-express",
     "description": "Webforms evolved.",
     "homepage": "https://enketo.org",
-    "version": "4.1.2",
+    "version": "4.1.3",
     "main": "./app.js",
     "engines": {
         "node": ">=14.8.0 <17",
@@ -46,8 +46,8 @@
         "csurf": "^1.11.0",
         "db.js": "^0.15.0",
         "debug": "^4.3.4",
-        "enketo-core": "^6.1.2",
-        "enketo-transformer": "2.1.5",
+        "enketo-core": "^6.1.3",
+        "enketo-transformer": "2.1.6",
         "evp_bytestokey": "^1.0.3",
         "express": "^4.18.1",
         "express-cls-hooked": "^0.3.8",