-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter errors after turning on strict mode #10719
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10719 +/- ##
=========================================
Coverage 84.55% 84.55%
Complexity 19977 19977
=========================================
Files 2633 2633
Lines 69316 69316
Branches 5596 5596
=========================================
Hits 58611 58611
Misses 8002 8002
Partials 2703 2703 ☔ View full report in Codecov by Sentry. |
path?: string | string[]; | ||
} | ||
|
||
interface Portal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the types from the source, which is available in the same code repo?
@@ -65,7 +65,7 @@ class ResourceImpl | |||
private res: JavaResource; | |||
|
|||
constructor(key: string | ResourceKey) { | |||
this.res = bean.getResource(key); | |||
this.res = bean.getResource(key) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace oupsie?
No description provided.