Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User friendly log message on job setup #110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

User friendly log message on job setup #110

wants to merge 4 commits into from

Conversation

pawelkaczor
Copy link
Contributor

Fix #93

@pawelkaczor pawelkaczor mentioned this pull request Jun 12, 2021
Open
@pawelkaczor
Copy link
Contributor Author

pawelkaczor commented Jun 12, 2021 •
edited
Loading

The changes have been already discussed (see #94) and rejected due to incorporation of new dependencies. I'm re-opening the PR in response to comment #93 (comment) by @felipebonezi

New dependencies incorporated by this PR:

  • net.redhogs.cronparser:cron-parser-core:3.5
  • joda-time:joda-time:2.3
  • org.apache.commons:commons-lang3:3.3.2

@pawelkaczor
Copy link
Contributor Author

Perhaps we should introduce new, optional module that would provide desired functionality.

felipebonezi
felipebonezi approved these changes Jun 12, 2021
View reviewed changes
Copy link
Contributor

@felipebonezi felipebonezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enragedginger
enragedginger requested changes Jun 15, 2021
View reviewed changes
Copy link
Owner

@enragedginger enragedginger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should take a different approach here. See my rationale here: #93 (comment)

@felipebonezi
Copy link
Contributor

I still think we should take a different approach here. See my rationale here: #93 (comment)

Is there any way to create an plugin that users choose to attach or not?
So, if developer wants to use the cron parser, than he must accept the libraries that goes with it.

@pawelkaczor
Copy link
Contributor Author

@felipebonezi I switched to https://github.com/eikek/calev#akka . Perhaps you will like it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enragedginger enragedginger enragedginger requested changes

@felipebonezi felipebonezi felipebonezi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve 'Setting up scheduled job ...' log message
3 participants
@pawelkaczor @felipebonezi @enragedginger