Skip to content

Commit

Permalink
Fix "Test is missing assertions" warnings
Browse files Browse the repository at this point in the history
Rails Edge produced some warnings:

- Test is missing assertions: `test_action_controller_gets_locale_setter`
- Test is missing assertions: `test_action_controller_gets_locale_suffix_helper`
- Test is missing assertions: `test_action_view_gets_locale_suffix_helper`

Those tests never worked because the assertion was missing (they were
returning false) and broke at a certain point in time
  • Loading branch information
tagliala committed May 27, 2024
1 parent 9d4bbfe commit 66d1b20
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions test/routing_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -620,15 +620,7 @@ def test_host_locales
end

def test_action_controller_gets_locale_setter
ActionController::Base.instance_methods.include?('set_locale_from_url')
end

def test_action_controller_gets_locale_suffix_helper
ActionController::Base.instance_methods.include?('locale_suffix')
end

def test_action_view_gets_locale_suffix_helper
ActionView::Base.instance_methods.include?('locale_suffix')
assert_includes ActionController::Base.private_instance_methods, :set_locale_from_url
end

# See https://github.com/enriclluelles/route_translator/issues/69
Expand Down

0 comments on commit 66d1b20

Please sign in to comment.