Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 8.0 #307

Merged
merged 1 commit into from
May 27, 2024
Merged

Allow Rails 8.0 #307

merged 1 commit into from
May 27, 2024

Conversation

theodorton
Copy link
Contributor

We're unable to test our project with edge Rails at the moment as route_translator doesn't officially support anything newer than 7.1 and the next version of Rails will be 8.0.

Ran the existing test suite against edge and they all seem to pass.

@coveralls
Copy link

coveralls commented May 27, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 3426d67 on Skalar:rails-8-0
into d5eddc2 on enriclluelles:master.

@tagliala
Copy link
Collaborator

Hi! Thanks for this PR

Can you please:

  1. Rebase from master
  2. Use 8.0 instead of 8.1. 8.0 will work for all the pre-release versions of Rails 8. Since Route Translator uses some Rails internals, we can't guarantee that it will be compatible with 8.0 stable until 8.0 will be released

route_translator.gemspec Outdated Show resolved Hide resolved
@theodorton
Copy link
Contributor Author

@tagliala thanks for the quick review :) I've rebased and pushed the correction you suggested.

@tagliala tagliala merged commit 44f8154 into enriclluelles:master May 27, 2024
20 of 21 checks passed
@tagliala
Copy link
Collaborator

Thanks, v14.1.2 pushed to rubygems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants