Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth.mdx for NameRegistered #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update eth.mdx for NameRegistered #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/registry/eth.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,6 @@ event NameRegistered(uint256 indexed hash, address indexed owner, uint expires);
event NameRenewed(uint256 indexed hash, uint expires);

// Controller
event NameRegistered(string name, bytes32 indexed label, address indexed owner, uint cost, uint expires);
event NameRegistered(string name, indexed bytes32 label, indexed address owner, uint256 baseCost, uint256 premium, uint256 expires);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
event NameRegistered(string name, indexed bytes32 label, indexed address owner, uint256 baseCost, uint256 premium, uint256 expires);
event NameRegistered(string name, bytes32 indexed label, address indexed owner, uint256 baseCost, uint256 premium, uint256 expires);

event NameRenewed(string name, bytes32 indexed label, uint cost, uint expires);
```
Loading