-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding L2 notes to Naming Contracts page. #354
base: master
Are you sure you want to change the base?
Conversation
Instead of relying on |
I intentionally left that out, because don't think that would be a preferred option, it's something that should be discouraged actually, in my opinion. First of all, you typically don't know what a contract address is going to be until you deploy it (you can probably simulate and derive that based on nonce, maybe, depending on the chain). So you don't even know what to set your ENS name's ETH record to until after you deploy usually. There is no forward-resolution check on the reverse registrar though, so technically you can set the reverse record first, and then work backwards to set that ETH address on whatever ENS name you set it to. Technically possible, but possibly confusing. However the bigger issue is that if you just call |
Hmmm I'm thinking along the lines of the "default names" concept — seems like something would have to happen in the constructor for that to work ? |
Worth mentioning that you can call Also worth mentioning that the name must forward resolve to the relevant address with the respective cointype for it to actually work. |
Also would be nice to reference this list of deployments vs duplicate it. |
Also adding note to subname registrar page.