Identical expiry date pagination fix #908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
storywithoutend
commented
Nov 4, 2024
storywithoutend
commented
- Bump ensjs to 4.0.2-alpha.5
- For name generators, switched from using Promise.all to a for-loop when processing subnames so that we don't overload the blockchain.
- Added tests on front end to check that names are not missing when querying more than 20 names with identical expiry dates or createdAt dates.
…ry-and-creation-dates
Deploying ens-app-v3 with
|
| Latest commit: |
5231083
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7a8bda8.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fet1573-names-pagination-wit.ens-app-v3.pages.dev |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.