Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix extend name bugs #909

Merged
merged 6 commits into from
Nov 8, 2024
Merged

fix extend name bugs #909

merged 6 commits into from
Nov 8, 2024
+311 −131

Conversation

storywithoutend
Copy link
Collaborator

@storywithoutend storywithoutend commented Nov 6, 2024 •
edited
Loading

Fixes:

  • Gas Estimate Error: Caused by allowing [Invalid ENS Name] to be selected as when clicking select all.
  • e2e test flakiness: Caused by the data not ready when "next" is clicked. Solved by making sure data is loaded before showing screen and adding more conditions for hooks to be enabled.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024 •
edited
Loading

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c486bc
Status: ✅  Deploy successful!
Preview URL: https://5092862b.ens-app-v3.pages.dev
Branch Preview URL: https://fix-e2e-multi-name-extension.ens-app-v3.pages.dev

View logs

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sugh01 sugh01 merged commit 0478c78 into main Nov 8, 2024
40 checks passed
@sugh01 sugh01 deleted the fix-e2e-multi-name-extension-bug branch November 8, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugh01 sugh01 sugh01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@storywithoutend @sugh01