-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EPNS embed sidebar notifications on Home page #1494
base: dev
Are you sure you want to change the base?
feat: EPNS embed sidebar notifications on Home page #1494
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @subhranshudas thanks very much for your PR! Some points/questions:
- You mentioned you tested on ropsten however it seems EPNS does not support ropsten, and also ENS doesn’t support Kovan (d’oh!), is there a way for me to test what the notification will look like if I have a name that’s soon expiring without registering one on mainnet?
- The EPNS plugin asks me to change to Kovan network intermittently, this should not happen.
- The sidebar should not be showing demo content when there are no notifications. It can perhaps link to a tutorial if the user has not opted in to the ENS channel yet.
Hello @LeonmanRolls,
|
Thanks @subhranshudas. Do you have a way to test the functionality with a name that is soon to expire without registering a new name on mainnet? |
Integration of EPNS Notifications Embed Feature on the Home Page
Description
On the Home page of the ENS app, when the user is connected to their account, we are basically showing an EPNS bell icon on click of which they will see a sidebar which has a list of notifications if they have "opted-in" (subscribed) to ENS channel via EPNS.
List of features added/changed
UX wise
Code wise
useEPNSEmbed
hook which is used in theHome
route wrapper and abstracts out the trigger & cleanup mechanism of the originalEmbedSDK
methods from the EPNS SDK. Feel free to change the init options here.embedsdk.esm.js
file (for now) to provide theEmbedSDK
features from the original EPNS-SDK package.Note: Currently we are transitioning to smaller individual packages, to avoid increasing the bundle size for ENS (or any dApp), we are now giving a build file which is going to be replaced by an NPM package shortly. So once that happens we can remove the build file and simply use in the
useEPNSEmbed
hook something like -How Has This Been Tested?
Locally
Unit Tests
Created/Updated the following tests which are passing -
Ran
npm test
on the entire code base -Checklist:
Screenshots