Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ExtendedDNSResolver to support more record types #331

Merged
merged 13 commits into from
May 1, 2024
Merged

Rewrite ExtendedDNSResolver to support more record types #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6db6444
Add hexToBytes()
Arachnid Feb 15, 2024
e95380c
First version of better parser
Arachnid Feb 19, 2024
c321f91
More tests
Arachnid Feb 20, 2024
4472f47
Text record support
Arachnid Feb 20, 2024
23a3d66
Remove console log
Arachnid Feb 20, 2024
513fbe1
Add support for easier encoding of EVM chain IDs
Arachnid Feb 21, 2024
c9535ae
Handle multiple spaces between records
Arachnid Feb 21, 2024
6fc58e6
Handle no spaces between quoted records
Arachnid Feb 21, 2024
38407f0
Add comment referencing ensip-11
Arachnid Feb 21, 2024
8dd3f11
unify utility contracts
mdtanrikulu Mar 26, 2024
63ca27e
Changesx in response to revie
Arachnid Apr 4, 2024
b479cd2
Merge pull request #342 from ensdomains/fix/unify-utility-contracts
mdtanrikulu Apr 4, 2024
d3d6b70
Merge branch 'staging' into feature/better-offchain-dns
mdtanrikulu Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/DNSClaimChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
pragma solidity ^0.8.4;

import "../dnssec-oracle/DNSSEC.sol";
import "../dnssec-oracle/BytesUtils.sol";
import "../dnssec-oracle/RRUtils.sol";
import "../utils/BytesUtils.sol";
import "../utils/HexUtils.sol";
import "@ensdomains/buffer/contracts/Buffer.sol";

Expand Down
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/DNSRegistrar.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ pragma solidity ^0.8.4;

import "@openzeppelin/contracts/utils/introspection/IERC165.sol";
import "@ensdomains/buffer/contracts/Buffer.sol";
import "../dnssec-oracle/BytesUtils.sol";
import "../dnssec-oracle/DNSSEC.sol";
import "../dnssec-oracle/RRUtils.sol";
import "../registry/ENSRegistry.sol";
import "../root/Root.sol";
import "../resolvers/profiles/AddrResolver.sol";
import "../utils/BytesUtils.sol";
import "./DNSClaimChecker.sol";
import "./PublicSuffixList.sol";
import "./IDNSRegistrar.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/OffchainDNSResolver.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import "../../contracts/resolvers/profiles/IAddrResolver.sol";
import "../../contracts/resolvers/profiles/IExtendedResolver.sol";
import "../../contracts/resolvers/profiles/IExtendedDNSResolver.sol";
import "@openzeppelin/contracts/utils/introspection/ERC165.sol";
import "../dnssec-oracle/BytesUtils.sol";
import "../dnssec-oracle/DNSSEC.sol";
import "../dnssec-oracle/RRUtils.sol";
import "../registry/ENSRegistry.sol";
import "../utils/HexUtils.sol";
import "../utils/BytesUtils.sol";

import {Address} from "@openzeppelin/contracts/utils/Address.sol";
import {LowLevelCallUtils} from "../utils/LowLevelCallUtils.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/RecordParser.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.11;

import "../dnssec-oracle/BytesUtils.sol";
import "../utils/BytesUtils.sol";

library RecordParser {
using BytesUtils for bytes;
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/TLDPublicSuffixList.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pragma solidity ^0.8.4;

import "../dnssec-oracle/BytesUtils.sol";
import "../utils/BytesUtils.sol";
import "./PublicSuffixList.sol";

/**
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnsregistrar/mocks/DummyParser.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pragma solidity ^0.8.4;

import "../../dnssec-oracle/BytesUtils.sol";
import "../../utils/BytesUtils.sol";
import "../RecordParser.sol";

contract DummyParser {
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/DNSSECImpl.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ pragma solidity ^0.8.4;
pragma experimental ABIEncoderV2;

import "./Owned.sol";
import "./BytesUtils.sol";
import "./RRUtils.sol";
import "./DNSSEC.sol";
import "./algorithms/Algorithm.sol";
import "./digests/Digest.sol";
import "../utils/BytesUtils.sol";
import "@ensdomains/buffer/contracts/Buffer.sol";

/*
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/RRUtils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//SPDX-License-Identifier: MIT
pragma solidity ^0.8.4;

import "./BytesUtils.sol";
import "../utils/BytesUtils.sol";
import "@ensdomains/buffer/contracts/Buffer.sol";

/**
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/algorithms/P256SHA256Algorithm.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ pragma solidity ^0.8.4;

import "./Algorithm.sol";
import "./EllipticCurve.sol";
import "../BytesUtils.sol";
import "../../utils/BytesUtils.sol";

contract P256SHA256Algorithm is Algorithm, EllipticCurve {
using BytesUtils for *;
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/algorithms/RSASHA1Algorithm.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
pragma solidity ^0.8.4;

import "./Algorithm.sol";
import "../BytesUtils.sol";
import "./RSAVerify.sol";
import "../../utils/BytesUtils.sol";
import "@ensdomains/solsha1/contracts/SHA1.sol";

/**
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/algorithms/RSASHA256Algorithm.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
pragma solidity ^0.8.4;

import "./Algorithm.sol";
import "../BytesUtils.sol";
import "./RSAVerify.sol";
import "../../utils/BytesUtils.sol";

/**
* @dev Implements the DNSSEC RSASHA256 algorithm.
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/algorithms/RSAVerify.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pragma solidity ^0.8.4;

import "../BytesUtils.sol";
import "./ModexpPrecompile.sol";
import "../../utils/BytesUtils.sol";

library RSAVerify {
/**
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/digests/SHA1Digest.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pragma solidity ^0.8.4;

import "./Digest.sol";
import "../BytesUtils.sol";
import "../../utils/BytesUtils.sol";
import "@ensdomains/solsha1/contracts/SHA1.sol";

/**
Expand Down
2 changes: 1 addition & 1 deletion contracts/dnssec-oracle/digests/SHA256Digest.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pragma solidity ^0.8.4;

import "./Digest.sol";
import "../BytesUtils.sol";
import "../../utils/BytesUtils.sol";

/**
* @dev Implements the DNSSEC SHA256 digest.
Expand Down
2 changes: 1 addition & 1 deletion contracts/ethregistrar/ETHRegistrarController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
pragma solidity ~0.8.17;

import {BaseRegistrarImplementation} from "./BaseRegistrarImplementation.sol";
import {StringUtils} from "./StringUtils.sol";
import {StringUtils} from "../utils/StringUtils.sol";
import {Resolver} from "../resolvers/Resolver.sol";
import {ENS} from "../registry/ENS.sol";
import {ReverseRegistrar} from "../reverseRegistrar/ReverseRegistrar.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/ethregistrar/StablePriceOracle.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
pragma solidity ~0.8.17;

import "./IPriceOracle.sol";
import "./StringUtils.sol";
import "../utils/StringUtils.sol";
import "@openzeppelin/contracts/access/Ownable.sol";
import "@openzeppelin/contracts/utils/introspection/IERC165.sol";

Expand Down
32 changes: 0 additions & 32 deletions contracts/ethregistrar/StringUtils.sol
View file
Open in desktop

This file was deleted.

Loading
Loading