Initial revision of MigrationHelper #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makoto
reviewed
Sep 16, 2024
contracts/utils/MigrationHelper.sol
Outdated
| ) external onlyController { | ||
| for (uint256 i = 0; i < tokenIds.length; i++) { | ||
| registrar.safeTransferFrom( | ||
| owner, |
There was a problem hiding this comment.
Is the owner the owner of this contract (aka DAO) or the actual name owner? If the latter, you may want to change to nameowner or something as onlyOwner at setMigrationTarget and owner here have different semantics.
There was a problem hiding this comment.
Looks like it's the actual name owner, because the owner of the name is what you need to transfer it
There was a problem hiding this comment.
owner in this context is the owner of the name, yes. It's passed in as a function parameter.
jefflau
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MigrationHelper would allow people to opt in to the ENSv2 migration ahead of time by calling
setApprovalForAllon the .eth registrar or Name Wrapper targeting this contract. This contract will be owned by the DAO; at migration time, the DAO can specify a migration target address (likely theL1MigrationController) and a controller contract or address that is authorized to make calls to migrate domains to this contract.Notably, this introduces a trusted dependency - a malicious DAO could use this contract to steal names from users who have elected to use it.