Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Resolution #11

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Universal Resolution #11

wants to merge 3 commits into from

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Oct 14, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024

Deploying ensips with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c68560
Status: ✅  Deploy successful!
Preview URL: https://ac9ee7e5.ensips.pages.dev
Branch Preview URL: https://ensip-universal-resolution.ensips.pages.dev

View logs

Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to explicitly state that callers must handle CCIP-Read reverts.

## Motivation

The process of resolving ENS names traditionally requires multiple onchain calls, and that an implementing developer has in-depth knowledge of ENS.
This is becoming more prevalent over time, especially with the introduction of wildcard resolution (ENSIP-10), and more recently cross-chain reverse resolution (ENSIP-19).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is becoming more prevalent over time, especially with the introduction of wildcard resolution (ENSIP-10), and more recently cross-chain reverse resolution (ENSIP-19).
Resolution is becoming more involved over time, especially with the introduction of wildcard resolution (ENSIP-10), and more recently cross-chain reverse resolution (ENSIP-19).


This function takes two parameters:

- `lookupAddress`: The address to resolve the name for, in **encoded** form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should clarify what encoding - text? Binary? Examples for, eg, Ethereum and Bitcoin would be valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants