[DRAFT] Introduce Chain Id 0 (EOA Chain Id) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucemans
changed the title
lucemans
force-pushed
the
ensip/chain-id-0
branch
from
c104d5f
to
b063d9e
Compare
Deploying ensips with
|
| Latest commit: |
c325c9f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f36242eb.ensips.pages.dev |
| Branch Preview URL: | https://ensip-chain-id-0.ensips.pages.dev |
lucemans
force-pushed
the
ensip/chain-id-0
branch
from
1183a0c
to
2329134
Compare
|
YAY!!! THIS IS GREAT! So glad it's moving forward. |
makoto
reviewed
Oct 29, 2024
ensips/x.md
Outdated
|
|
||
| There are multiple routes around implementing this; | ||
|
|
||
| For the short-term; we can already use this specification in our apps today (see Appendix A). |
There was a problem hiding this comment.
Does out apps mean https://app.ens.domains/ or you mean anyone's app? Probably better to rephrase to be more explicit
makoto
reviewed
Oct 29, 2024
|
|
||
| ## Specification | ||
|
|
||
| This ENSIP aims to extend the functionality introduced in [ENSIP-9](./9) and [ENSIP-11](./11) and simply relies on the same functionality. |
There was a problem hiding this comment.
Probably it should mention https://docs.ens.domains/ensip/19 as step 9 also incorporates chainid 0 as a fallback mechanism.
makoto
reviewed
Oct 29, 2024
|
|
||
| ### Public Resolver | ||
|
|
||
| The public resolver could choose to implement a fallback mechanism for EOA addresses. |
There was a problem hiding this comment.
Can UniversalResolver also implement the logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; https://namespaces.chainagnostic.org/eip155/caip10#caip-10 assumes evm chain id
0is "EOA" chain id.We would like to extend this functionality into ENS leveraging the already existing ENSIP-9.
Still looking for feedback on: