-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross chain resolver compatibility with resolver interface and ENS UI #37
Fix cross chain resolver compatibility with resolver interface and ENS UI #37
Conversation
Hi. |
It seems to be an error on the Cloudflare function that prevents it from being resolved. Wondering why the manual test passed well. |
That's because of I think |
Thank you for the contribution! However, as @makoto points out, this will not work on wildcard names - these methods will only function if the target has been set for the exact name, which is not what we want. A better solution would be to fix the UI so that it doesn't warn like this on resolvers that implement these interfaces via |
It appear that if we don't implement these addr, text and contenthash interface, ENS UI won't resolve the CCIP at all |
Problem
Current cross chain resolver doesn't implement standard public resolver interfaces (IAddrResolver, IAddressResolver, ITextResolver and IContentHashResolver). Causing ENS UI to not support the cross chain resolver and show a warning on updating the resolver.
Solution
Additional Improvements
workspace:*
for evmgateway dependenciesTest
We have tested our L1Resolver contract on https://web.getlaika.app/ and confirmed that it's working correctly on Sepolia <-> OP Sepolia CCIP Read.
However, I can't test on https://app.ens.domains/ because https://ccip-v2.ens.xyz/ post request has frozen forever. So, resolver records aren't loaded.
Note: disputegame.eth name hash is 0x438bfe3fc990665148f8ac1638323ab84054a5c22a1ab61fe63cebc3040129cb