Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stylebox styling consistency tweaks #139

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat: stylebox styling consistency tweaks #139

merged 2 commits into from
Feb 28, 2024

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Feb 14, 2024

changes:

  • added padding to scrollbar
  • made divider line continue to under the scrollbar track to give the impression that the scrollbar is part of the scrollbox
  • using css with data-* attributes instead of react props for better performance

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2b7566
Status: ✅  Deploy successful!
Preview URL: https://2a9a56ce.thorin.pages.dev
Branch Preview URL: https://feat-scrollbox-tweaks.thorin.pages.dev

View logs

@TateB TateB merged commit 540b4f8 into main Feb 28, 2024
4 checks passed
@TateB TateB deleted the feat/scrollbox-tweaks branch February 28, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storywithoutend storywithoutend storywithoutend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TateB @storywithoutend