Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): links for mobile dropdown, remove 'as' from props #144

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix(Dropdown): links for mobile dropdown, remove 'as' from props #144

merged 2 commits into from
Apr 10, 2024

Conversation

talentlessguy
Copy link
Contributor

image
image

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2024 •
edited
Loading

Deploying thorin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12671ed
Status:⚡️  Build in progress...

View logs

lucemans
lucemans approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/reference/mdx/molecules/Dropdown.docs.mdx Outdated Show resolved Hide resolved
@talentlessguy talentlessguy merged commit 10e5c6c into main Apr 10, 2024
3 of 4 checks passed
@talentlessguy talentlessguy deleted the dropdown-mobile-fix branch April 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucemans lucemans lucemans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talentlessguy @lucemans