Filename input in Cloud File Browser for write component. #12228
Conversation
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
|
Marked draft, as it is stacked on top of #12208 |
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 3.0.3 to 3.0.5. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v3.0.5/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
farmaazon
force-pushed
the
wip/farmaazon/cfb-in-write
branch
from
4a37a0f to
45bb3f5
Compare
farmaazon
changed the title
farmaazon
requested review from
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
| * @param keepAlive - when set, the `activity` instance will be kept between drop-down closing | ||
| * and opening. The activity component must not change it type (when being a ref) and provide | ||
| * `name` option explicitly. |
There was a problem hiding this comment.
An alternative approach would be <KeepAlive v-if="..."><component ...></KeepAlive><component v-else ...> (This could be packaged into a ConditionalKeepAlive slotted utility component to avoid writing the <component ....> twice). This would avoid the name requirement and the restriction on changing types.
There was a problem hiding this comment.
when v-else is hit, the cache will be gone I'm afraid...
...unless we put this in another KeepAlive.
There was a problem hiding this comment.
I don't understand. The reason for the conditional is to disable KeepAlive when the activity hasn't requested it. In that case, losing the cache is intended.
There was a problem hiding this comment.
I imagined keepAlive be requested per activity, so for example we have FileBrowser activity which is kept alive, but same drop-down could have another activity which is not: but even when that second activity is set, the FileBrowser is still cached.
| @keydown.delete.stop | ||
| @keydown.arrow-left.stop | ||
| @keydown.arrow-right.stop | ||
| @keydown.enter="acceptCurrentFile() === false || $event.stopPropagation()" |
There was a problem hiding this comment.
Should this be conditional? If the filename box is focused, I don't think I would expect Enter to be handled by the parent handler if the filename is invalid (empty).
Pull Request Description
Fixes #12112
Screencast.From.2025-02-04.16-41-59.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.