Fix Drive table #12397
Fix Drive table #12397
Conversation
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0,
MrFlashAccount,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
…" calls and replace with `refetchInterval` when necessary
|
Something is still broken with the scroll bar 
|
app/gui/src/dashboard/components/AriaComponents/Button/Button.tsx
Outdated
Show resolved
Hide resolved
app/gui/src/dashboard/components/dashboard/columnHeading/ModifiedColumnHeading.tsx
Outdated
Show resolved
Hide resolved
| @@ -337,9 +337,7 @@ const ButtonContent = memo(function ButtonContent(props: ButtonContentProps) { | |||
| styles={styles} | |||
| hideLoader={hideLoader} | |||
| /> | |||
| <Text color="inherit" truncate="1" className={styles.text()}> | |||
There was a problem hiding this comment.
We used to have a span with className={styles.text()}, haven't we?
There was a problem hiding this comment.
well, i tried extracting the css directly and it doesn't seem to work.
try running this commit in dev (staging env) and create a project execution (no repeats to minimize load, but long timezone to (try to) trigger the truncate class):
| } | ||
|
|
||
| /** A text display with an icon. */ | ||
| export function IconDisplay<IconType extends string>(props: IconDisplayProps<IconType>) { |
There was a problem hiding this comment.
when I told about patterns I meant only the ICON_DISPLAY_STYLES part,
There was a problem hiding this comment.
i guess, but i do want a dedicated component to avoid having to rewrite the markup (and get it right) every time, unless you have a better idea
There was a problem hiding this comment.
When we didn't have any abstractions for styling, we used to add purely stylistic components like <Stack /> <Grid /> or similar. Now we have tailwind-variants which allows us to encapsulate visuals and make them reusable, this makes the stylistic components obsolete (thats why we don't have them). I'm not against this component, but lets add a ./components/patterns/ directory and move the ICON_DISPLAY_STYLES there if you don't mind. (I'd like to rename ICON_DISPLAY_STYLES to ICON_WITH_TEXT_PATTERN)
See: https://github.com/chakra-ui/chakra-ui/blob/main/packages/react/src/components/flex/flex.tsx - this better be a construtor fn that returns styles : https://panda-css.com/docs/concepts/patterns#flex
| data-current | ||
| aria-current="page" | ||
| textSelection="none" | ||
| elementType="a" | ||
| icon={icon} | ||
| isCurrent={isCurrent} |
There was a problem hiding this comment.
IconDisplay isCurrent ? isDisabled ?
| @@ -104,14 +103,11 @@ function DashboardInner(props: DashboardProps) { | |||
| const initialProjectName = initialLocalProjectPath != null ? null : initialProjectNameRaw | |||
|
|
|||
| const categoriesAPI = useCategoriesAPI() | |||
|
|
|||
There was a problem hiding this comment.
Where did we move the refetch directories though?
There was a problem hiding this comment.
we no longer batch refetch directories since there is no longer a tree, no? so only one directory ever needs to be refetched at any time
There was a problem hiding this comment.
Hm, that makes sense, but we need to be sure we added the refetch in options object, but I have no idea how to avoid turning the listDirectory options constructor into a hook (as we still rely on feature-flags here). So if you have an idea how to tackle this, I'm happy to delete these lines.
There was a problem hiding this comment.
i think my preferred solution would be to add a hook to return the required variables (enable refetch and refetch interval), and add an extra parameter to the constructor (required so that the user must explicitly opt out) that takes in the return type of that hook. thoughts?
There was a problem hiding this comment.
In that case it's easy to forget to add this, the same query folks use in the Editor IIRC, and I think it makes sense to avoid spreading logic across the app
There was a problem hiding this comment.
alternatively we can just have a hook useListDirectory maybe
There was a problem hiding this comment.
re: easy to forget, there's a mandatory new property to the listDirectory options constructor so at the very least it'd be noticeable if someone intentionally avoids passing it
…to wip/sb/flat-assets-fixes
… a single item can be dragged
|
@MrFlashAccount a heads up that this PR fixes default weights in |
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.