-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for join_kind #12502
Merged
Merged
Add icons for join_kind #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Storybook is successfully deployed!📊 Dashboard:
|
jdunkerley
approved these changes
Mar 14, 2025
Still need to fix and add some tests |
kazcw
reviewed
Mar 14, 2025
app/gui/src/project-view/components/GraphEditor/widgets/WidgetSelection.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetSelection.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetSelection.vue
Outdated
Show resolved
Hide resolved
marthasharkey
approved these changes
Mar 14, 2025
GregoryTravis
approved these changes
Mar 14, 2025
52e05e6
to
d78e7ab
Compare
566050e
to
384425b
Compare
vitvakatu
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-libs-API-change-Table
Marks a PR that changes the public API of Standard.Table
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #12368
Adds icons to dropdowns.
Only when they are set by libs for now (automatically off doc comments may be a future change).
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.