Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for join_kind #12502

Merged
merged 23 commits into from
Mar 22, 2025
Merged

Add icons for join_kind #12502

merged 23 commits into from
Mar 22, 2025

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 14, 2025

Pull Request Description

Closes #12368

Adds icons to dropdowns.
Only when they are set by libs for now (automatically off doc comments may be a future change).

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link

github-actions bot commented Mar 14, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@AdRiley AdRiley changed the title Wip/adr/add icons to drop downs Add icons for join_kind Mar 14, 2025
@AdRiley AdRiley marked this pull request as ready for review March 14, 2025 12:33
@AdRiley
Copy link
Member Author

AdRiley commented Mar 14, 2025

Still need to fix and add some tests

@AdRiley AdRiley force-pushed the wip/adr/add-icons-to-drop-downs branch 2 times, most recently from 52e05e6 to d78e7ab Compare March 20, 2025 10:13
@AdRiley AdRiley force-pushed the wip/adr/add-icons-to-drop-downs branch from 566050e to 384425b Compare March 21, 2025 09:45
@github-actions github-actions bot added the -libs-API-change-Table Marks a PR that changes the public API of Standard.Table label Mar 21, 2025
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 21, 2025
@jdunkerley jdunkerley added CI: Keep up to date Automatically update this PR to the latest develop. and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Mar 21, 2025
@jdunkerley jdunkerley added this to the 2025-Q1 Release milestone Mar 21, 2025
@mergify mergify bot merged commit 1dfc5a6 into develop Mar 22, 2025
74 of 77 checks passed
@mergify mergify bot deleted the wip/adr/add-icons-to-drop-downs branch March 22, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs-API-change-Table Marks a PR that changes the public API of Standard.Table CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to have icons on drop down menus
6 participants