Implement reload cache clearing for CloudRequestCache

[GregoryTravis]

Pull Request Description

This also refactors ReloadDetector to reduce the boilerplate needed to implement reload-triggered cache clearing.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.
• If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
  or the Snowflake database integration, a run of the Extra Tests has been scheduled.
  • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

[radeusgd]

I'm wondering if it could be worth it to encapsulate this piece of code into a method, so that we keep it in one place in case the method call pattern changes. But perhaps unnecessary.

private void checkReload() {
  ReloadDetector.INSTANCE.clearOnReloadIfRegistered(this);
}

[GregoryTravis]

I've simplified this by making ReloadDetector static and removing INSTANCE, since it's not necessary.

[radeusgd]

The APIRequestCache seems to not have this register call. Is that by design or omission?

[radeusgd]

Oh now I noticed - the base class does not have it but the implementation CloudRequestCache does. Ok.

I'd suggest to add a note in the APIRequestCache doc comment mentioning that implementations should call register.

Or perhaps couldn't we make the APIRequestCache call it in its constructor? So that implementations call it automatically. I'm worried someone creating a new implementation may easily forget this call so ideally I'd like to structure the code in such a way that it is hard to forget it :)

[GregoryTravis]

I wanted to allow subclasses to decide if they want to use ReloadDetector, so I've just added some documentation to APIRequestCache.

[radeusgd]

Ah ok, I thought that it would fail with the 'not registered exception' but didn't notice you have clearOnReloadIfNotRegistered so it checks the registration.

Makes sense now, thanks for clarifying! And the note in the docs is appreciated.

[radeusgd]

Overall changes look very good.

Just one nitpick if we can try to make APIRequestCache easier to not-forget registering. But feel free to ignore if not as easy as I thought.

[hubertp]

Looks alright minus some potential race-conditions