Remove "X Components" label when editing existing component #12535
+29
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
kazcw
approved these changes
Mar 18, 2025
| <span class="selfArgInfo">{{ selfTypeName ?? 'Input' }} Components</span> | ||
| <SvgIcon class="selfArgInfoArrow" name="folder_closed" /> | ||
| <span v-if="mode.mode === 'componentBrowsing'" class="selfArgInfo" | ||
| >{{ selfTypeName ?? 'Input' }} Components</span |
There was a problem hiding this comment.
I think it's a bit confusing to display Any Components here--the user may not read Any as referring to a type, in which case it could seem like we meant All Components. It would help if we format the component type in monospace.
There was a problem hiding this comment.
There was a problem hiding this comment.
After all we agreed, that, if type is unknown, we don't display the label at all. In that case, Any should be never visible.
jdunkerley
added
the
CI: No changelog needed
…/fix-component-editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #12530
Also fixed the case when the type is not yet available (we display "Any Components" in that case)
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.