Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious import warning #12578

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Fix spurious import warning #12578

merged 5 commits into from
Mar 20, 2025

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Mar 20, 2025 •
edited
Loading

Fixes #12376

Pull Request Description

Avoid processing the same import statement in AmbiguousImportsAnalysis in some cases.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 20, 2025
@Akirathan Akirathan self-assigned this Mar 20, 2025
@Akirathan Akirathan marked this pull request as ready for review March 20, 2025 11:08
@Akirathan Akirathan merged commit 9476960 into develop Mar 20, 2025
71 of 72 checks passed
@Akirathan Akirathan deleted the wip/akirathan/12376-duplicated-import-warn branch March 20, 2025 18:26
@enso-bot enso-bot bot mentioned this pull request Mar 20, 2025
Closed
@jdunkerley jdunkerley added this to the 2025-Q1 Release milestone Mar 21, 2025
farmaazon pushed a commit that referenced this pull request Mar 21, 2025
@Akirathan @farmaazon
Fix spurious import warning (#12578)
4bc9248 
* Add reproducer test

* Avoid duplicate import warnings for the same import statement

* Simplify the reproducer test

* Check if resolved names are allowed to clash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@Akirathan Akirathan

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
2025-Q1 Release
Development

Successfully merging this pull request may close these issues.

Spurious duplicated import warning
4 participants
@Akirathan @hubertp @JaroslavTulach @jdunkerley