Skip to content

WIP Refactor DB_Column as 'subtype' of Column #13116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: develop
Choose a base branch
from
Draft

WIP Refactor DB_Column as 'subtype' of Column #13116

wants to merge 37 commits into from

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

radeusgd added 30 commits May 16, 2025 21:10
@radeusgd
WIP DB
a83d508
@radeusgd
fixes
d67a3d4
@radeusgd
fixing refinements and using appropriate narrowings for accessing DB_…
756bf11 
…Column internals in implementation
@radeusgd
assertions, rename operators
4dd563e
@radeusgd
fixing types, calls to helper methods
2fc177b
@radeusgd
more fixes
8806875
@radeusgd
fix to_vector and some others
0a99eb5
@radeusgd
align let
a5e9aac
@radeusgd
fixes to Multi Value dispatch when dataflow error is passed through A…
de12ac7 
… & B
@radeusgd
trying to rely on intersection type for this_column to then avoid so …
c4f2f2d 
…many casts
@radeusgd
fix intersection type for Numeric_Column impl
a70f2cd
@radeusgd
apply the same simplification for DB_Column
5e6a7e8
@radeusgd
remove old sigs
d717b42
@radeusgd
WIP amending refinements
23b81a4
@radeusgd
workaround for bug: DB_Table & DB_Column & Column & Numeric_Column issue
aac1305
@radeusgd
Revert "apply the same simplification for DB_Column"
3c2add6 
This reverts commit 639693a
@radeusgd
reorder
28ee7f5
@radeusgd
workaround for bug
fa6a824
@radeusgd
fixse
80f854a
@radeusgd
Reapply "apply the same simplification for DB_Column"
ed6f5a4 
This reverts commit 148a571.
@radeusgd
Revert "workaround for bug: DB_Table & DB_Column & Column & Numeric_C…
471d46c 
…olumn issue"

This reverts commit dc774b5.
@radeusgd
Revert "workaround for bug"
6c74d5a 
This reverts commit 3b15552.
@radeusgd
fix calls in round_decimal
0178354
@radeusgd
fixes
21f2db2
@radeusgd
update replace params
534b03d
@radeusgd
workaround for somehow unresolved method
2193d0c
@radeusgd
more fixes
64f2c43
@radeusgd
more fixes 2
968fe50
@radeusgd
fixing expressions on DB_Column, some simplifications
e6201aa
@radeusgd
fix missing cast
1c49daf
@radeusgd radeusgd self-assigned this May 17, 2025
@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label May 17, 2025
@github-actions github-actions bot added -libs-API-change-Database Marks a PR that changes the public API of Standard.Database -libs-API-change-Table Marks a PR that changes the public API of Standard.Table labels May 17, 2025
@radeusgd radeusgd force-pushed the wip/rw/base-column-type-2 branch from ee9463b to e23100a Compare May 17, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley will be requested when the pull request is marked ready for review jdunkerley is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis will be requested when the pull request is marked ready for review GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley will be requested when the pull request is marked ready for review AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 will be requested when the pull request is marked ready for review 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp will be requested when the pull request is marked ready for review hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan will be requested when the pull request is marked ready for review Akirathan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@radeusgd radeusgd

Labels
-libs-API-change-Database Marks a PR that changes the public API of Standard.Database -libs-API-change-Table Marks a PR that changes the public API of Standard.Table CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radeusgd