Skip to content

Commit

Permalink
Always run without a timeout in v-e-c task
Browse files Browse the repository at this point in the history
Ignore the TIMEOUT param. Mention in the param description that it's
now ignored and deprecated.

Ref: https://issues.redhat.com/browse/EC-1030
  • Loading branch information
simonbaird committed Dec 19, 2024
1 parent 68e90c0 commit 277cfc5
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,10 @@ spec:

- name: TIMEOUT
type: string
description: Timeout setting for `ec validate`.
default: "5m0s"
description: >
This param is deprecated and will be removed in future. Its value is ignored. EC will
be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.)
default: ""

Check failure on line 134 in tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml

View workflow job for this annotation

GitHub Actions / Lint

Task 'verify-enterprise-contract' defines parameter 'TIMEOUT', but it's not used anywhere in the spec
- name: WORKERS
type: string
Expand Down Expand Up @@ -224,7 +226,8 @@ spec:
- "$(params.WORKERS)"
# NOTE: The syntax below is required to negate boolean parameters
- "--info=$(params.INFO)"
- "--timeout=$(params.TIMEOUT)"
# No timeout for EC, though Tekton may apply a timeout
- "--timeout=0"
- "--strict=false"
- "--show-successes"
- "--effective-time=$(params.EFFECTIVE_TIME)"
Expand Down

0 comments on commit 277cfc5

Please sign in to comment.