Skip to content

Commit

Permalink
Add a comment about local build gotcha
Browse files Browse the repository at this point in the history
I considered different ways of "fixing" the problem, e.g. by
cleaning out the dist directory in the docker file, or by creating
the binaries in a different directory, but in the end I felt like it
wasn't worth the extra complexity, so here's a comment to warn about
it instead.
  • Loading branch information
simonbaird committed Jan 3, 2024
1 parent bf32abc commit d11abe2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Dockerfile.dist
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ RUN microdnf -y --nodocs --setopt=keepcache=0 install git-core jq
COPY --from=download /download/cosign /usr/local/bin/cosign

# Copy all the binaries so they're available to extract and download
# (Beware if you're testing this locally it will copy everything from
# your dist directory, not just the freshly built binaries.)
COPY --from=build /build/dist/ /usr/local/bin/

# Copy the one ec binary that can run in this container
Expand Down

0 comments on commit d11abe2

Please sign in to comment.