Add Markdown Summary and Status Icons in Report #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
+ Coverage 85.07% 85.11% +0.04%
==========================================
Files 66 66
Lines 5372 5400 +28
==========================================
+ Hits 4570 4596 +26
- Misses 802 804 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seanconroy2021
changed the title
seanconroy2021
force-pushed
the
HACBS-2672
branch
from
c593054 to
825f8f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zregvart
reviewed
Oct 2, 2023
seanconroy2021
force-pushed
the
HACBS-2672
branch
2 times, most recently
from
563bd9d to
62ee5b3
Compare
seanconroy2021
force-pushed
the
HACBS-2672
branch
from
56f97b3 to
a69b08f
Compare
seanconroy2021
force-pushed
the
HACBS-2672
branch
3 times, most recently
from
9b6bda8 to
20ee120
Compare
simonbaird
reviewed
Oct 3, 2023
| } | ||
|
|
||
| writeMarkdownField(&markdownBuffer, "Time", r.created.UTC().Format("2006-01-02 15:04:05"), "") | ||
| writeMarkdownField(&markdownBuffer, "Name", " ", "") |
There was a problem hiding this comment.
What's the reason to have a "Name" row that's always empty? Should we just remove this row?
seanconroy2021
force-pushed
the
HACBS-2672
branch
from
20ee120 to
39f2fc1
Compare
Implement generateMarkdownSummary() in report.go for Markdown CLI output Add test cases for generateMarkdownSummary() in report_test.go Introduce new output option summary-markdown for GitHub Action Add status icon to Markdown summary resolves: HACBS-2672 Signed-off-by: Sean Conroy [email protected]
seanconroy2021
force-pushed
the
HACBS-2672
branch
from
39f2fc1 to
05e11b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary-markdownfor generating Markdown summaries.jira story: https://issues.redhat.com/browse/HACBS-2672
Blocked Until @simonbaird update success
notes:
need to be squashed and given better commit message