Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context persistence of TMPDIR in acceptance #1067

Merged

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Oct 3, 2023

The Context wasn't returned from the variables function so changes to it were not persisted.

The `Context` wasn't returned from the `variables` function so changes
to it were not persisted.
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1067 (42c6aae) into main (1620b78) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          66       66           
  Lines        5365     5365           
=======================================
  Hits         4563     4563           
  Misses        802      802           
Flag Coverage Δ
acceptance 68.81% <ø> (ø)
generative 4.50% <ø> (ø)
integration 66.44% <ø> (ø)
unit 71.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zregvart zregvart merged commit 4361bfc into enterprise-contract:main Oct 4, 2023
10 checks passed
@zregvart zregvart deleted the pr/fix-tmpdir-in-acceptance branch October 4, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants