Ensure evaluators are not destroyed if reused #1532
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
==========================================
+ Coverage 80.59% 87.29% +6.70%
==========================================
Files 66 77 +11
Lines 4761 5165 +404
==========================================
+ Hits 3837 4509 +672
+ Misses 924 656 -268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We changed the life cycle of evaluators to the top of the command, and mistakenly left the destruction of the evaluator tied to the lifecycle of validating a single component. This causes files created for one evalator and shared between component validations or evaluators inaccessible. An error such as: ``` get compiler options: capabilities not opened: open /tmp/ec-work-299517100/capabilities.json: no such file or directory ``` would be reported. This changes the destruction of the evaluator to be in line with the new lifecycle.
zregvart
force-pushed
the
pr/evaluator-lifecycle
branch
from
d9920ab to
6cee4a1
Compare
|
The acceptance tests were tweaked, they did not fail when I removed the change from the production code because the evaluator was executing fast enough for the issue not to manifest itself. Now each component's image is unique, so evaluation takes a bit more, but enough to trigger the issue. |
|
/retest |
1 similar comment
|
/retest |
|
Seems like failure is due to a random Tekton resolver error: |
|
/retest |
|
The |
We changed the life cycle of evaluators to the top of the command, and mistakenly left the destruction of the evaluator tied to the lifecycle of validating a single component.
This causes files created for one evalator and shared between component validations or evaluators inaccessible. An error such as:
would be reported.
This changes the destruction of the evaluator to be in line with the new lifecycle.