Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update konflux application-api dependency url #1743

Merged

Conversation

simonbaird
Copy link
Member

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (de191f2) to head (a04c45f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
+ Coverage   80.28%   86.86%   +6.58%     
==========================================
  Files          67       78      +11     
  Lines        4874     5217     +343     
==========================================
+ Hits         3913     4532     +619     
+ Misses        961      685     -276     
Flag Coverage Δ
acceptance 71.84% <ø> (?)
generative 80.28% <ø> (ø)
integration 80.28% <ø> (ø)
unit 80.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/validate/image.go 95.23% <ø> (+0.31%) ⬆️
internal/applicationsnapshot/input.go 93.65% <ø> (ø)
internal/applicationsnapshot/report.go 78.08% <ø> (+10.11%) ⬆️
...ation_snapshot_image/application_snapshot_image.go 77.71% <ø> (+20.57%) ⬆️
internal/image/validate.go 73.58% <ø> (+0.94%) ⬆️
internal/kubernetes/client.go 75.75% <ø> (+18.18%) ⬆️
internal/policy/fake.go 50.00% <ø> (ø)

... and 36 files with indirect coverage changes

@simonbaird
Copy link
Member Author

Failure logs include "no required module provides package github.com/konflux-ci/application-api/api/v1alpha1". Not sure what to do about it..

@zregvart
Copy link
Member

zregvart commented Jul 4, 2024

Failure logs include "no required module provides package github.com/konflux-ci/application-api/api/v1alpha1". Not sure what to do about it..

Run a go mod tidy in the acceptance directory.

@zregvart
Copy link
Member

zregvart commented Jul 4, 2024

Added a commit for the update in acceptance

@zregvart zregvart merged commit e1cc4f5 into enterprise-contract:main Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants