Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description text for multi-term exclude advice #1744

Conversation

simonbaird
Copy link
Member

If there is more than one term provided in a violation's metadata, there will now be a correctly formatted exclude config suggestion for each one.

Ref: https://issues.redhat.com/browse/EC-703

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (de191f2) to head (01eb8bd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
+ Coverage   80.28%   86.91%   +6.63%     
==========================================
  Files          67       78      +11     
  Lines        4874     5229     +355     
==========================================
+ Hits         3913     4545     +632     
+ Misses        961      684     -277     
Flag Coverage Δ
acceptance 71.83% <66.66%> (?)
generative 80.35% <100.00%> (+0.06%) ⬆️
integration 80.35% <100.00%> (+0.06%) ⬆️
unit 80.35% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/evaluator/conftest_evaluator.go 87.94% <100.00%> (+3.53%) ⬆️

... and 40 files with indirect coverage changes

If there is more than one term provided in a violation's metadata,
there will now be a correctly formatted exclude config suggestion
for each one.

Ref: https://issues.redhat.com/browse/EC-703
@simonbaird simonbaird force-pushed the multliple-terms-in-exclude-note branch from d944311 to 01eb8bd Compare July 4, 2024 03:48
@zregvart zregvart merged commit 8a00d84 into enterprise-contract:main Jul 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants