v-e-c: print debug logging at bottom of output #1791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bestavros <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 80.76% 80.76%
=======================================
Files 68 68
Lines 4918 4918
=======================================
Hits 3972 3972
Misses 946 946
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Yeah, I kinda lumped a bunch of issues into #1769, |
zregvart
reviewed
Jul 26, 2024
Comment on lines
+190
to
+191
| - "2>" | ||
| - "debug.log" |
There was a problem hiding this comment.
We can't use shell redirects here, these are arguments passed to ec directly, not a shell invocation...
|
Done in #1769. Let's close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.redhat.com/browse/EC-565
Simple change to the
verify-enterprise-contractTask that should capture debug output in a file, then print it at the bottom of the output.This hasn't been tested, so I'm submitting it as a draft.
cc @zregvart