KFLUXBUGS-1505 Fix EC OOM by specifying workers #1817
Conversation
robnester-rh
force-pushed
the
KFLUXBUGS-1505
branch
from
afc5068 to
c460ba4
Compare
|
We were discussing a way for this to be 1 by default so we don't require a change in the release service, perhaps the Task's default can be 1? |
Yes. Forgot about this. I think setting 1 in the Task (which is different than the default on the CLI, 5) makes sense given the resource constraints we set on the Task. |
This commit attempts to resolve an issue resulting in ec OOM when attempting to validate images with large SBOMs by providing a flag to limit the number of parallel works to reduce memory usage. The verify-enterprise-contract task has also been updated to utilize this parameter, with an associated default of "1" workers. Signed-off-by: robnester-rh <[email protected]>
robnester-rh
force-pushed
the
KFLUXBUGS-1505
branch
from
c460ba4 to
192b98a
Compare
|
Updated the default value in the task to "1". |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
+ Coverage 80.74% 80.75% +0.01%
==========================================
Files 68 68
Lines 4954 4958 +4
==========================================
+ Hits 4000 4004 +4
Misses 954 954
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -150,6 +150,7 @@ mark (?) sign, for example: --output text=output.txt?show-successes=false | |||
| --snapshot:: Provide the AppStudio Snapshot as a source of the images to validate, as inline | |||
| JSON of the "spec" or a reference to a Kubernetes object [<namespace>/]<name> | |||
| -s, --strict:: Return non-zero status on non-successful validation. Defaults to true. Use --strict=false to return a zero status code. (Default: true) | |||
| --workers:: Number of workers to use for validation. Defaults to 5. (Default: 5) | |||
There was a problem hiding this comment.
The first 5 is in Portuguese while the second 5 is in English.
This commit attempts to resolve an issue resulting in ec OOM when attempting to validate images with large SBOMs by providing a flag to limit the number of parallel works to reduce memory usage.