Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC-785 Document the URI formats accepted by cli #1878

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

robnester-rh
Copy link
Contributor

This commit documents the different URI formats supported by ec for the policy & data source locations. The information in this documentation addition is drawn from the underlying go-gather library.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (5e8c830) to head (9357c04).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1878   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          68       68           
  Lines        4989     4989           
=======================================
  Hits         4022     4022           
  Misses        967      967           
Flag Coverage Δ
generative 80.61% <ø> (ø)
integration 80.61% <ø> (ø)
unit 80.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


A local file path scheme, such as the following, may be utilized.

* `file://<path>:`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing : intentional here?

Suggested change
* `file://<path>:`
* `file://<path>`

maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Initially theses were headings, but in editing things, they were moved around. I'll remove the : char

You may also use the `git::` prefix to specify a Git repository URL. The following formats are supported:

* `git::[email protected]:<user>/<repo>.git?ref=<reference>//<path>`:
* `git::example.com/<org>/<repo>.git?ref=<reference>//<path>`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again the : char, is an asciidoc formatting thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Initially theses were headings, but in editing things, they were moved around. I'll remove the : char

Comment on lines +613 to +615
You may also use the `http::` prefix to specify an HTTPS URL.

* `http::example.com/file.ext`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does http really mean https here?

Suggested change
You may also use the `http::` prefix to specify an HTTPS URL.
* `http::example.com/file.ext`
You may also use the `https::` prefix to specify an HTTPS URL.
* `https::example.com/file.ext`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it does, just wondering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-gather allows for http(s) transfers, but from ECs point of view, all http transport should be https. The prefix is http:: however.


You may also use the `oci::` prefix to specify an OCI registry URL:

* `oci://<registry>/<repository>:<tag>`
Copy link
Member

@simonbaird simonbaird Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, maybe include the digest formats as well, e.g.:

Suggested change
* `oci://<registry>/<repository>:<tag>`
* `oci://<registry>/<repository>:<tag>`
* `oci::<registry>/<repository>:<tag>`
* `oci://<registry>/<repository>@<digest>`
* `oci::<registry>/<repository>:<tag>@<digest>`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. Will do.

This commit documents the different URI formats supported by ec for the
policy & data source locations. The information in this documentation
addition is drawn from the underlying go-gather library.

Signed-off-by: robnester-rh <[email protected]>
@robnester-rh robnester-rh merged commit 76488f4 into enterprise-contract:main Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants