Use source.config instead of configuration #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "global" `configuration` is deprecated. Instead, the `config` attribute for a certain policy source should be used. This commit updates acceptance tests and docs to use the new format. Ref: EC-688 Signed-off-by: Luiz Carvalho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 68 68
Lines 5050 5050
=======================================
Hits 4080 4080
Misses 970 970
Flags with carried forward coverage won't be shown. Click here to find out more.
|
simonbaird
reviewed
Aug 28, 2024
| ], | ||
| "include": [ | ||
| "always_checked", | ||
| "@salsa_one_collection" |
There was a problem hiding this comment.
Out of scope, but I wondered - is this an intentional or unintentional comedy misspelling?
simonbaird
reviewed
Aug 28, 2024
| exclude: [] | ||
| config: | ||
| include: | ||
| - '@minimal' |
There was a problem hiding this comment.
Not sure what the behavior is when both legacy "collections" and "include" are set, but should this be as follows?
Suggested change
| - '@minimal' | |
| - "*" |
to match line 761 before this PR?
There was a problem hiding this comment.
That's a good question. Arguably, even the old example was a bit odd. I think this probably better captures the intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "global"
configurationis deprecated. Instead, theconfigattribute for a certain policy source should be used.This commit updates acceptance tests and docs to use the new format.
Ref: EC-688