Update to go 1.22 #1902
Update to go 1.22 #1902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
- Coverage 80.81% 74.10% -6.71%
==========================================
Files 68 88 +20
Lines 5050 5747 +697
==========================================
+ Hits 4081 4259 +178
- Misses 969 1488 +519
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -1 +1 @@ | |||
| golang 1.21.9 | |||
| golang 1.22.5 | |||
There was a problem hiding this comment.
1.22.6 is newer, perhaps use that? I see the brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22 is at go version go1.22.5 (Red Hat 1.22.5-1.el9) linux/amd64, makes sense to be on the same patch version.
I guess we could enforce that all versions used here are matched in CI somehow? Would that be something of value?
There was a problem hiding this comment.
Yeah. Not sure if we can build the project if the version on the builder image is older (even just at the patch version). Need to play with it further.
There was a problem hiding this comment.
Following up in #1917.
I guess we could enforce that all versions used here are matched in CI somehow? Would that be something of value?
Maybe let's see if not doing that causes any issues?
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| ## Build | |||
|
|
|||
| FROM docker.io/library/golang:1.21 AS build | |||
| FROM docker.io/library/golang:1.22 AS build | |||
There was a problem hiding this comment.
Not sure if we want to, but we could pin to the patch version here...
| FROM docker.io/library/golang:1.22 AS build | |
| FROM docker.io/library/golang:1.22.5 AS build |
There was a problem hiding this comment.
I think it's ok to just use 1.22. Go is usually pretty stable between patch releases.
Ref: EC-598 Signed-off-by: Luiz Carvalho <[email protected]>
Ref: EC-598