Build and release EC images together. #2211
Open
+256
−1,192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
=======================================
Coverage 72.69% 72.69%
=======================================
Files 88 88
Lines 7622 7622
=======================================
Hits 5541 5541
Misses 2081 2081
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks good. Looking forward to tomorrow's demo/walkthrough. |
zregvart
reviewed
Dec 11, 2024
Comment on lines
+53
to
+54
| # TODO: Can't use Konflux's git-clone Task because that requires a security context not provided | ||
| # to the ServiceAccount running this pipeline (securityContext.runAsUser: 0). |
There was a problem hiding this comment.
Pointer to an issue to get this resolved upstream?
| - name: url | ||
| value: https://github.com/lcarva/release-service-bundles.git | ||
| value: https://github.com/lcarva/build-definitions.git |
There was a problem hiding this comment.
Perhaps we can keep that version of the git-clone task in this repository instead?
The sast-snyk-check Task does not provide an `image-digest` parameter. Instead, users are expected to profide image references that include the digest via the `image-url` parameter. Signed-off-by: Luiz Carvalho <[email protected]>
This is recommended by Tekton and fixes a violation found by tektor[1]. [1] https://github.com/lcarva/tektor Signed-off-by: Luiz Carvalho <[email protected]>
This commit changes the build process so the Tekton bundle is built in the same build pipeline that builds the CLI image. This has the main advantage of creating a close relationship between the two images. The bundle image, for example, references the CLI image by digest. It also simplifies the build process. As such, the build pipeline for the bundle is removed. Ref: EC-911 Signed-off-by: Luiz Carvalho <[email protected]>
This commit changes the tenant release pipeline so it understands that both the CLI and the bundle images are built within the same build Pipeline. It also removes the need to use different release Pipelines for each image. Signed-off-by: Luiz Carvalho <[email protected]>
|
/retest Konflux, are you there? |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. EC-911
See commit messages for more information.