Implement Osso #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbauch
commented
Dec 16, 2020
Comment on lines
+158
to
+160
| if raw_info&.created_at.present? | ||
| Time.zone.parse(raw_info.created_at) | ||
| elsif raw_info.auth_time.present? | ||
| elsif raw_info&.auth_time.present? |
There was a problem hiding this comment.
this was throwing a no method error with raw_info being nil
sbauch
commented
Dec 16, 2020
|
|
||
| class Osso < Provider | ||
| OFFICIAL_NAME = "SAML SSO".freeze | ||
| SETTINGS_URL = "https://ossoapp.com".freeze # TODO |
There was a problem hiding this comment.
this can read off ENV to send to admin ui
sbauch
commented
Dec 16, 2020
| # Learn more about Osso at https://ossoapp.com | ||
|
|
||
| class Osso < Provider | ||
| OFFICIAL_NAME = "SAML SSO".freeze |
There was a problem hiding this comment.
I'd probably want to use ENV vars here if I were actually adding this to forem. if its an internal community, it might be "Sign in with EnterpriseCo Okta". but in multi-tenancy, we expect folks to be more generic and not use "Osso".
sbauch
commented
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as an example of adding Osso to a real world Rails app.
The base application, forem/forem is the open source community software that powers dev.to.
Forem already implemented OAuth for Github, Twitter and Facebook, so this was a straightforward task of fitting Osso into the existing
Authentication::Providers.There were a couple of sticky points -
• forem's omniauth hash handling didnt find our
raw_infowhich was unexpected, maybe TODO• Honeybadger was awfully hard to turn off!