Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Support Python 3.12 #1281

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Conversation

larsoner
Copy link
Collaborator

This isn't a good fix, but numpy.distutils is gone in Python 3.12. This should at least allow it to build in non-editable mode.

@prabhuramachandran
Copy link
Member

Thanks @larsoner! What would be the best way to do this while supporting editable builds?

@larsoner
Copy link
Collaborator Author

Not sure. And several variants of what I have here do not seem to work, e.g. the patches used here:

conda-forge/mayavi-feedstock#77

I think in theory the right move here is to migrate to using setuptools directly instead of anything numpy.distutils-related. But I'm not sure how trivial that will be...

@tkoyama010
Copy link
Contributor

To support Python3.12. We should be noted whether vtk's 9.3 will be compatible with Python 3.12.
https://pypi.org/project/vtk

@larsoner
Copy link
Collaborator Author

Probably not on PyPI but conda-forge has it already, which triggered conda-forge/mayavi-feedstock#77. See

I haven't tested it locally but I would be surprised if it did not work.

Copy link
Member

@prabhuramachandran prabhuramachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am fine with these changes if it does the job.

@prabhuramachandran prabhuramachandran merged commit 8ae6e5c into enthought:master Dec 9, 2023
8 checks passed
@prabhuramachandran
Copy link
Member

@larsoner -- many thanks for this. Sorry for the delay in merging this.

@larsoner larsoner deleted the 312 branch February 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants