Button and Slider Widgets #844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
=========================================
- Coverage 50.85% 50.76% -0.1%
=========================================
Files 263 265 +2
Lines 23846 24046 +200
Branches 3252 3270 +18
=========================================
+ Hits 12128 12206 +78
- Misses 10931 11053 +122
Partials 787 787
Continue to review full report at Codecov.
|
prabhuramachandran
requested changes
Dec 24, 2019
|
|
||
| def _scene_changed(self, old, new): | ||
| if self._actors_added: | ||
| old.remove_wdigets(self.widgets) |
There was a problem hiding this comment.
Typo, and the fact that this wasn't caught suggests no tests, can you please add a simple test so this is exercised?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the user to add a slider, button to the scene and associate callbacks with these widgets.