Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better detection of apple silicon arch #486

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Better detection of apple silicon arch #486

merged 4 commits into from
Feb 6, 2025

Conversation

itziakos
Copy link
Member

@itziakos itziakos commented Feb 5, 2025 •
edited
Loading

  • On macos platform.machine will report x86_64 when the running python is executed through Rosetta. So we need to special case the code and workaround this behaviour
  • mocks have been also updated to better mask the actual running system when running the tests

@itziakos itziakos requested a review from dpinte February 5, 2025 17:37
dpinte
dpinte approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@itziakos itziakos merged commit 6a7b604 into main Feb 6, 2025
17 checks passed
@itziakos itziakos deleted the fix-macos-arm-system-arch-detection branch February 6, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itziakos @dpinte