[NayNay] Only substrate #329
Conversation
- updated trasnfer to only need substrate rather than the entire entropy instance
There was a problem hiding this comment.
@rh0delta can you take this PR a bit further and show what it looks like to remove entropy completely from interatction and command. Right now we still have loadEntropyCLI or loadEntropyTUI happening upstream and the idea I had was that instantiatioin is where errors are handled etc. I want to see the value complete and that it works and we really can get away from loading entropy
|
I shoulda said this seems real promising as a path, nice observation! |
the idea here was to remove the instantiation of entropy where we can. however, transfer still requires some data coming from the entropy instance, i.e the signer pair coming from the keyring, so we are unable to completely remove the load of entropy upstream. The most that could be done currently, is the removal of the need for the entropy instance in the class itself. |
|
@mixmix may have found a way to completely remove entropy instance from transfer, both in TUI and CLI. please give it a re-review. |
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.