[NayNay] Balance for any address & transfer (using only substrate api)

[rh0delta]

Related Issue(s)

• Resolves entropy balance <address> should take any address #237

Proposed Changes

• updated balance for prg cli to be able to retrieve balance for any address
• using newly exposed utility method to getSubstrate from sdk

Testing

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

• I have performed a self-review of my code.
• I have added tests.
• I have commented my code.
• I have included a CHANGELOG.md entry.
• I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

[rh0delta]

Build's will continue to fail for this PR until the addition to the sdk is released.

Re: https://github.com/entropyxyz/sdk/pull/435/files

[mixmix]

@mixmix reviewing this
@frankiebee working on SDK thing for this

[mixmix]

Excited for this. Needs more tests to prove it works, and needs to not regress the API

[mixmix]

merge conflicts now here too @rh0delta

[mixmix]

Found some bugs that I fixed in this PR: #327

[mixmix]

Found that when I have a newly fauceted account this function doesn't work:

➜  cli git:(mixmix/any-balance) entropy balance --all | jq
[
  {
    "account": "5HNMFB1fELqSAEMkRtUMA6ACs1jD693h16Gt8ixvBS6csJRq",
    "balance": 2,
    "symbol": "BITS"
  },
  {
    "account": "5E4DpqmtnxBA6WbExNvFnJv2Hw5BsUpk8KnAVZLbBMWZVTXb",
    "balance": 0,
    "symbol": "BITS"
  }
]
➜  cli git:(mixmix/any-balance) entropy balance 5HNMFB1fELqSAEMkRtUMA6ACs1jD693h16Gt8ixvBS6csJRq | jq
Provided [account=5HNMFB1fELqSAEMkRtUMA6ACs1jD693h16Gt8ixvBS6csJRq] is not a valid substrate address

[mixmix]

yeah have tried with a registered account and still getting that error "not a valid substrate address"

[mixmix]

ok fixed it in that PR : 619ff78

@rh0delta I've seen us slip with if/ else + boolean logic a couple times now. I didn't spot it either till I did some closer testing. I think we need to EITHER write tests over such things, OR try to write much simpler (and more verbose) if/ else if/ else logic. Have a look at the solution in that linked commit. It's more nesting, but more clear (to me at least)

[mixmix]

Mix to re-review

[mixmix]

I like this, it's really interesting seeing how little we might need the full SDK... also begs the question "what is it even used for", "what is our policy for when we use SDK and when we use raw substrate?"

I'd like to see us not go to full class methods - I think keeping some of the pattern of EntropyBase but making a SubstrateBase class that we inherit from will keep the patterns of the repo more coherent and give use support for the logging and other things that we need, tidy up need to pass around substrate etc.

Have left more notes and thinking as I went with more detail.
Nice work!

[rh0delta]

@mixmix mistakenly made most of the pr updates in this PR #329, so we can merge that into this one once reviewed

changes made, mix ooo, need a review from frankie

[frankiebee]

I like this, it's really interesting seeing how little we might need the full SDK... also begs the question "what is it even used for", "what is our policy for when we use SDK and when we use raw substrate?"

you probably asking this because you have'nt needed to deal with signing. The sdk is meant to make signing and the format checking of registering with programs simple.

[frankiebee]

Looks good to me thanks for the work!