Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NayNay] Complete Import #307

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

[NayNay] Complete Import #307

wants to merge 1 commit into from

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Nov 13, 2024

Related Issue(s)

Proposed Changes

  • on import, only the address and basic account info is added to the users config
  • this adds the existing verifying keys to the account info

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have added tests.
  • I have commented my code.
  • I have included a CHANGELOG.md entry.
  • I have updated documentation in github.com:entropyxyz/entropy-docs, where necessary.

- on import, only the address and basic account info is added to the users config
- this adds the existing verifying keys to the account info
@rh0delta
Copy link
Contributor Author

Going to hold off on making any changes to this and put it on the back-burner. Had a chat with frankie and it looks like either more design is needed for this or there are necessary changes needed for the keyring in order to pull this through to the finish line.

@rh0delta rh0delta linked an issue Nov 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete import
1 participant