Use spawn_blocking
when processing synedrion messages
#1285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested by @fjarri here:
entropyxyz/manul#91 (comment)
Since synedrion's message processing methods are synchronous and computationally heavy, it does not make sense to run them in async tokio tasks as this may prevent the executor from moving other tasks forward.
This PR uses
tokio::task::spawn_blocking
to run them as blocking, syncronous tasks instead.Unfortunately this does not appear to give any improvement in performance when testing signing with 8 parties.
Since we will be soon swapping this out for the protocol execution loop provided by manul, it probably makes no difference whether or not we merge this. But gonna put it up anyway.