Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CLA Assistant bot's GitHub Action workflow. #963

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

vitropy
Copy link
Contributor

@vitropy vitropy commented Jul 26, 2024

This pull request adds the CLA Assistant workflow to the repository, which adds a check to ensure that contributors are legally entering into a binding Contributor License Agreement when they contribute to the repository.

Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - pending getting CI passing - even though i know the CI failure is unrelated to the PR.

@vitropy can you rebase / merge latest master. It looks like this is due to a new clippy rule barking at something in the time crate - i think on master time has been bumped from 0.3.34 to 0.3.36. Which presumably fixes this (there is a change on the line being complained about).

Copy link
Member

@JesseAbram JesseAbram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on what @ameba23 said

vitropy and others added 2 commits July 29, 2024 10:14
It is unlikely that users belonging to the `entropyxyz` GitHub Organization are required to sign the CLA. This commit ensures Organization members are not prompted for a CLA signature.
@vitropy
Copy link
Contributor Author

vitropy commented Jul 29, 2024

Gonna merge since the lint that failed earlier passed. Thanks, everyone!

@vitropy vitropy merged commit f712a85 into master Jul 29, 2024
12 of 13 checks passed
@vitropy vitropy deleted the cla-assistant branch July 29, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants