Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things coming up in the process of working on entropyxyz/synedrion#170:
ExecutionResult
indev
Display
impl to generate descriptions for protocol errors instead of a separate methodNoProtocolErrors
stub type to use for protocols that don't generate provable errors (instead of the previous()
which for whatever reason does not implDisplay
)ProtocolMessage
. Fixes Bundle protocol message parts in method signatures #48ProtocolError::required_*
methods into onerequired_messages()
. This makes it easier to write in complicated cases, since all requirements are bundled together. Also the user can now declare which parts of the main message they want to keep, instead of saving everything, which is generally not needed.Protocol::verify_*_is_invalid()
mandatory to implement. There is no good default implementation for them that doesn't lead to runtime errors.