Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API adjustments for CGGMP'24 #79

Merged
merged 10 commits into from
Jan 1, 2025
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Dec 31, 2024

Various things coming up in the process of working on entropyxyz/synedrion#170:

  • Expose ExecutionResult in dev
  • Use Display impl to generate descriptions for protocol errors instead of a separate method
  • Add a NoProtocolErrors stub type to use for protocols that don't generate provable errors (instead of the previous () which for whatever reason does not impl Display)
  • Add associated data support that's needed for KeyRefresh (and probably for signing too). Fixes Associated data in evidences #10
  • Bundle message parts into ProtocolMessage. Fixes Bundle protocol message parts in method signatures #48
  • Merge ProtocolError::required_* methods into one required_messages(). This makes it easier to write in complicated cases, since all requirements are bundled together. Also the user can now declare which parts of the main message they want to keep, instead of saving everything, which is generally not needed.
  • Made Protocol::verify_*_is_invalid() mandatory to implement. There is no good default implementation for them that doesn't lead to runtime errors.

@fjarri fjarri self-assigned this Dec 31, 2024
@coveralls
Copy link

coveralls commented Dec 31, 2024

Pull Request Test Coverage Report for Build 12573957722

Details

  • 181 of 310 (58.39%) changed or added relevant lines in 10 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.2%) to 70.141%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/dev/run_sync.rs 0 2 0.0%
manul/src/session/transcript.rs 6 8 75.0%
manul/src/session/evidence.rs 113 127 88.98%
manul/src/session/session.rs 20 38 52.63%
manul/src/protocol/round.rs 21 44 47.73%
manul/src/combinators/chain.rs 5 75 6.67%
Files with Coverage Reduction New Missed Lines %
manul/src/combinators/chain.rs 2 56.82%
manul/src/protocol/round.rs 3 61.27%
Totals Coverage Status
Change from base Build 12496132950: 1.2%
Covered Lines: 1837
Relevant Lines: 2619

💛 - Coveralls

@fjarri fjarri marked this pull request as ready for review January 1, 2025 19:23
@fjarri fjarri merged commit c6a8972 into entropyxyz:master Jan 1, 2025
8 checks passed
@fjarri fjarri deleted the api-adjustment branch January 1, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle protocol message parts in method signatures Associated data in evidences
2 participants