Jawn/GetSetRemovePrograms #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiebee
requested changes
Jan 23, 2024
There was a problem hiding this comment.
move all your functions into dev
- get: returns array of pointers with the configs
get () : ProgramData[] - set: takes an array of pointers with the config and calls change_program_instance
set (newList: ProgramData[]) - remove: removes a pointer from user programs list and calls set under the hood
- add: append a new program pointer to the original list and then sets then new list
export interface ProgramData {
hash: string
config: unknown //? what ever the config is supposed to be
}
also include a function which returns the programs bytecode and config |
* wip: get programs dev working * updated yaml * update tests * catch program deploy * wip: getting programs to work * format programInfo * wip * programPointer -> pointer * fix registration * signing * include hash for sign * recompiled program * types and config. plus program changes --------- Co-authored-by: jawndiego <[email protected]>
frankiebee
added a commit
that referenced
this pull request
Jan 29, 2024
* update index and programs to allow for new key type: programDeployKey create new programDevClass * types update (#280) * Jawn/GetSetRemovePrograms (#281) * types update * types * programs set, get, and remove with notes * move dev functions to new files * dev stuff * set get remove and add for user signer flow * new types * removed authorization, checked registered * documentation * register update * Frankie/dev and tests (#282) * wip: get programs dev working * updated yaml * update tests * catch program deploy * wip: getting programs to work * format programInfo * wip * programPointer -> pointer * fix registration * signing * include hash for sign * recompiled program * types and config. plus program changes --------- Co-authored-by: jawndiego <[email protected]> --------- Co-authored-by: Frankie <[email protected]> * fix for build * update changelog --------- Co-authored-by: jawn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates include: